This change adds checks for register read errors and returns correct
error code.

Cc: Jacopo Mondi <jacopo+rene...@jmondi.org>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Hans Verkuil <hans.verk...@cisco.com>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
Cc: Mauro Carvalho Chehab <mche...@s-opensource.com>
Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com>
---
 drivers/media/i2c/ov772x.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index 283ae2c..c56f910 100644
--- a/drivers/media/i2c/ov772x.c
+++ b/drivers/media/i2c/ov772x.c
@@ -1169,8 +1169,15 @@ static int ov772x_video_probe(struct ov772x_priv *priv)
                return ret;
 
        /* Check and show product ID and manufacturer ID. */
-       pid = ov772x_read(client, PID);
-       ver = ov772x_read(client, VER);
+       ret = ov772x_read(client, PID);
+       if (ret < 0)
+               return ret;
+       pid = ret;
+
+       ret = ov772x_read(client, VER);
+       if (ret < 0)
+               return ret;
+       ver = ret;
 
        switch (VERSION(pid, ver)) {
        case OV7720:
-- 
2.7.4

Reply via email to