On Thu, Apr 19, 2018 at 11:17:58AM +0100, Rui Miguel Silva wrote: > Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device > infrastructure support to be used in this type of systems that do not have > internal subdevices besides the CSI. > > Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> > --- > drivers/staging/media/imx/imx-media-dev.c | 16 +++++++++++----- > .../staging/media/imx/imx-media-internal-sd.c | 3 +++ > drivers/staging/media/imx/imx-media.h | 3 +++ > 3 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media-dev.c > b/drivers/staging/media/imx/imx-media-dev.c > index f67ec8e27093..a8afe0ec4134 100644 > --- a/drivers/staging/media/imx/imx-media-dev.c > +++ b/drivers/staging/media/imx/imx-media-dev.c > @@ -92,6 +92,9 @@ static int imx_media_get_ipu(struct imx_media_dev *imxmd, > struct ipu_soc *ipu; > int ipu_id; > > + if (imxmd->no_ipu_present)
It's sort of nicer if variables don't have a negative built in because otherwise you get confusing double negatives like "if (!no_ipu) {". It's not hard to invert the varible in this case, because the only thing we need to change is imx_media_probe() to set: + imxmd->ipu_present = true; regards, dan carpenter