Hi Stanimir,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Venus-updates/20180426-030344
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/media/platform/qcom/venus/core.c: In function 
'venus_enumerate_codecs':
>> drivers/media/platform/qcom/venus/core.c:225:1: warning: the frame size of 
>> 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^

vim +225 drivers/media/platform/qcom/venus/core.c

   181  
   182  static int venus_enumerate_codecs(struct venus_core *core, u32 type)
   183  {
   184          const struct hfi_inst_ops dummy_ops = {};
   185          struct venus_inst inst;
   186          unsigned int i;
   187          u32 codec, codecs;
   188          int ret;
   189  
   190          if (core->res->hfi_version != HFI_VERSION_1XX)
   191                  return 0;
   192  
   193          memset(&inst, 0, sizeof(inst));
   194          mutex_init(&inst.lock);
   195          inst.core = core;
   196          inst.session_type = type;
   197          if (type == VIDC_SESSION_TYPE_DEC)
   198                  codecs = core->dec_codecs;
   199          else
   200                  codecs = core->enc_codecs;
   201  
   202          ret = hfi_session_create(&inst, &dummy_ops);
   203          if (ret)
   204                  return ret;
   205  
   206          for (i = 0; i < MAX_CODEC_NUM; i++) {
   207                  codec = (1 << i) & codecs;
   208                  if (!codec)
   209                          continue;
   210  
   211                  ret = hfi_session_init(&inst, 
to_v4l2_codec_type(codec));
   212                  if (ret)
   213                          goto done;
   214  
   215                  ret = hfi_session_deinit(&inst);
   216                  if (ret)
   217                          goto done;
   218          }
   219  
   220  done:
   221          hfi_session_destroy(&inst);
   222          mutex_destroy(&inst.lock);
   223  
   224          return ret;
 > 225  }
   226  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to