Hi Sakari, Thank you for the patch.
On Monday, 7 May 2018 15:47:22 EEST Sakari Ailus wrote: > The omap3isp driver checked whether the second argument (the new > configuration) to the ISP statistics is NULL. This is the pointer to the > user-given argument and is never NULL. Remove the check. > > Reported-by: "Gustavo A. R. Silva" <[email protected]> > Suggested-by: Laurent Pinchart <[email protected]> > Signed-off-by: Sakari Ailus <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> > --- > drivers/media/platform/omap3isp/ispstat.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/ispstat.c > b/drivers/media/platform/omap3isp/ispstat.c index > 529cd8fb29b1..34a91125da36 100644 > --- a/drivers/media/platform/omap3isp/ispstat.c > +++ b/drivers/media/platform/omap3isp/ispstat.c > @@ -542,12 +542,6 @@ int omap3isp_stat_config(struct ispstat *stat, void > *new_conf) struct ispstat_generic_config *user_cfg = new_conf; > u32 buf_size = user_cfg->buf_size; > > - if (!new_conf) { > - dev_dbg(stat->isp->dev, "%s: configuration is NULL\n", > - stat->subdev.name); > - return -EINVAL; > - } > - > mutex_lock(&stat->ioctl_lock); > > dev_dbg(stat->isp->dev, -- Regards, Laurent Pinchart
