Hi Bingbu, I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180917-135744 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/i2c/imx319.c: In function 'imx319_set_stream': >> drivers/media/i2c/imx319.c:2146:2: error: implicit declaration of function >> '__v4l2_ctrl_grab'; did you mean 'v4l2_ctrl_grab'? >> [-Werror=implicit-function-declaration] __v4l2_ctrl_grab(imx319->vflip, enable); ^~~~~~~~~~~~~~~~ v4l2_ctrl_grab cc1: some warnings being treated as errors vim +2146 drivers/media/i2c/imx319.c 2111 2112 static int imx319_set_stream(struct v4l2_subdev *sd, int enable) 2113 { 2114 struct imx319 *imx319 = to_imx319(sd); 2115 struct i2c_client *client = v4l2_get_subdevdata(sd); 2116 int ret = 0; 2117 2118 mutex_lock(&imx319->mutex); 2119 if (imx319->streaming == enable) { 2120 mutex_unlock(&imx319->mutex); 2121 return 0; 2122 } 2123 2124 if (enable) { 2125 ret = pm_runtime_get_sync(&client->dev); 2126 if (ret < 0) { 2127 pm_runtime_put_noidle(&client->dev); 2128 goto err_unlock; 2129 } 2130 2131 /* 2132 * Apply default & customized values 2133 * and then start streaming. 2134 */ 2135 ret = imx319_start_streaming(imx319); 2136 if (ret) 2137 goto err_rpm_put; 2138 } else { 2139 imx319_stop_streaming(imx319); 2140 pm_runtime_put(&client->dev); 2141 } 2142 2143 imx319->streaming = enable; 2144 2145 /* vflip and hflip cannot change during streaming */ > 2146 __v4l2_ctrl_grab(imx319->vflip, enable); 2147 __v4l2_ctrl_grab(imx319->hflip, enable); 2148 2149 mutex_unlock(&imx319->mutex); 2150 2151 return ret; 2152 2153 err_rpm_put: 2154 pm_runtime_put(&client->dev); 2155 err_unlock: 2156 mutex_unlock(&imx319->mutex); 2157 2158 return ret; 2159 } 2160 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
