On Sun, 2009-12-20 at 22:02 -0500, Devin Heitmueller wrote:
> On Mon, Dec 14, 2009 at 11:19 AM, Mauro Carvalho Chehab
> <mche...@infradead.org> wrote:
> > Em Mon, 14 Dec 2009 11:10:50 -0500
> > Devin Heitmueller <dheitmuel...@kernellabs.com> escreveu:
> >
> >> On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho Chehab
> >> <mche...@infradead.org> wrote:
> >> >> I can't pull. Your site is not responding.
> >> >
> >> > Hmm... it seems a temporary failure. It is working now.
> >>
> >> That is strange (works fine from here). You reported a similar issue
> >> trying to pull one of Michael Krufky's trees last week. I will have
> >> to keep an eye on it.
> >
> > Yep.
> >
> > Btw, there are a few CodingStyle issues. Please send later a patch fixing
> > it.
> >
> > I'll be reviewing the patch series.
> >
> > Cheers,
> > Mauro
>
> Sorry about the delay on this. I took a pass over the files and
> cleaned up the bulk of the codingstyle issues. The remaining issues
> on the cx18-driver.c were pre-existing and the change is not obvious
> (probably needs input from the maintainer).
Hmmm on the current v4l-dvb tree, the command
$ v4l/scripts/checkpatch.pl --no-tree --strict \
-f linux/drivers/media/video/cx18/cx18-driver.c
yields warnings about pre-existing >80 column lines and
LINUX_VERSION_CODE checks.
Was there something else?
Regards,
Andy
> There is still one
> warning about an "#if 0" case in cx18-alsa-main.c, but this is being
> left there because it is a hook into the mixer routines, which are
> currently not supported (there is a cx18-alsa-mixer.c file but none of
> the controls are implemented yet).
>
> I added the patches to the original hvr-1600-alsa-2 tree, since the
> tree has not been merged yet.
>
> Devin
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
