Now the equivalent of FRACT_CMP() is added in v4l2 common internal API
header.

Cc: Matt Ranostay <matt.ranos...@konsulko.com>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
Cc: Hans Verkuil <hansv...@cisco.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com>
---
* v3
- Add Acked-by line

 drivers/media/platform/vivid/vivid-vid-cap.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c 
b/drivers/media/platform/vivid/vivid-vid-cap.c
index 1599159..f19c701 100644
--- a/drivers/media/platform/vivid/vivid-vid-cap.c
+++ b/drivers/media/platform/vivid/vivid-vid-cap.c
@@ -1824,9 +1824,6 @@ int vivid_vid_cap_g_parm(struct file *file, void *priv,
        return 0;
 }
 
-#define FRACT_CMP(a, OP, b)    \
-       ((u64)(a).numerator * (b).denominator  OP  (u64)(b).numerator * 
(a).denominator)
-
 int vivid_vid_cap_s_parm(struct file *file, void *priv,
                          struct v4l2_streamparm *parm)
 {
@@ -1847,14 +1844,14 @@ int vivid_vid_cap_s_parm(struct file *file, void *priv,
        if (tpf.denominator == 0)
                tpf = webcam_intervals[ival_sz - 1];
        for (i = 0; i < ival_sz; i++)
-               if (FRACT_CMP(tpf, >=, webcam_intervals[i]))
+               if (V4L2_FRACT_COMPARE(tpf, >=, webcam_intervals[i]))
                        break;
        if (i == ival_sz)
                i = ival_sz - 1;
        dev->webcam_ival_idx = i;
        tpf = webcam_intervals[dev->webcam_ival_idx];
-       tpf = FRACT_CMP(tpf, <, tpf_min) ? tpf_min : tpf;
-       tpf = FRACT_CMP(tpf, >, tpf_max) ? tpf_max : tpf;
+       tpf = V4L2_FRACT_COMPARE(tpf, <, tpf_min) ? tpf_min : tpf;
+       tpf = V4L2_FRACT_COMPARE(tpf, >, tpf_max) ? tpf_max : tpf;
 
        /* resync the thread's timings */
        dev->cap_seq_resync = true;
-- 
2.7.4

Reply via email to