Em Fri, 2 Nov 2018 09:59:31 -0300 Mauro Carvalho Chehab <mchehab+sams...@kernel.org> escreveu:
> Hi Zhi-san, > > Em Mon, 29 Oct 2018 15:22:55 -0700 > Yong Zhi <yong....@intel.com> escreveu: > > > Add IPU3-specific meta formats for parameter > > processing and 3A, DVS statistics: > > > > V4L2_META_FMT_IPU3_PARAMS > > V4L2_META_FMT_IPU3_STAT_3A > > > > Signed-off-by: Yong Zhi <yong....@intel.com> > > --- > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > > include/uapi/linux/videodev2.h | 4 ++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > > b/drivers/media/v4l2-core/v4l2-ioctl.c > > index 6489f25..abff64b 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1299,6 +1299,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > case V4L2_META_FMT_VSP1_HGO: descr = "R-Car VSP1 1-D Histogram"; > > break; > > case V4L2_META_FMT_VSP1_HGT: descr = "R-Car VSP1 2-D Histogram"; > > break; > > case V4L2_META_FMT_UVC: descr = "UVC payload header metadata"; > > break; > > + case V4L2_META_FMT_IPU3_PARAMS: descr = "IPU3 processing parameters"; > > break; > > + case V4L2_META_FMT_IPU3_STAT_3A: descr = "IPU3 3A statistics"; > > break; > > > > default: > > /* Compressed formats */ > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index f0a968a..bdccd7a 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -718,6 +718,10 @@ struct v4l2_pix_format { > > #define V4L2_META_FMT_UVC v4l2_fourcc('U', 'V', 'C', 'H') /* UVC > > Payload Header metadata */ > > #define V4L2_META_FMT_D4XX v4l2_fourcc('D', '4', 'X', 'X') /* D4XX > > Payload Header metadata */ > > > > +/* Vendor specific - used for IPU3 camera sub-system */ > > +#define V4L2_META_FMT_IPU3_PARAMS v4l2_fourcc('i', 'p', '3', 'p') /* IPU3 > > params */ > > +#define V4L2_META_FMT_IPU3_STAT_3A v4l2_fourcc('i', 'p', '3', 's') /* IPU3 > > 3A statistics */ > > Where's the documentation for those two new formats? The best is to > always add the documentation bits for V4L2 uAPI stuff at the same > patch, as it makes easier for us to review. Found it. It is at patch 3. > > > + > > /* priv field value to indicates that subsequent fields are valid. */ > > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > > > > > > Thanks, > Mauro Thanks, Mauro