Hi Sakari, On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote: [...] > @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh, > v4l2_std_id std) > > return v4l2_subdev_call(priv->src_sd, video, s_std, std); > > } > > > > +static int capture_g_selection(struct file *file, void *fh, > > + struct v4l2_selection *s) > > +{ > > + struct capture_priv *priv = video_drvdata(file); > > + > > + switch (s->target) { > > + case V4L2_SEL_TGT_CROP: > > + case V4L2_SEL_TGT_CROP_DEFAULT: > > + case V4L2_SEL_TGT_CROP_BOUNDS: > > + case V4L2_SEL_TGT_NATIVE_SIZE: > > The NATIVE_SIZE is for devices such as sensors. It doesn't make sense here.
Should this be documented in Documentation/media/uapi/v4l/v4l2- selection-targets.rst ? There it only mentions when to make it writeable. > With that removed, > > Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> Thank you, I'll remove that line. regards Philipp