As warned by smatch:

        drivers/staging/media/sunxi/cedrus/cedrus.c: 
drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: 
potential null dereference 'ctx->ctrls'.  (kzalloc returns null)

While here, remove the memset(), as kzalloc() already zeroes the
struct.

Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
---
 drivers/staging/media/sunxi/cedrus/cedrus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c 
b/drivers/staging/media/sunxi/cedrus/cedrus.c
index 44c45c687503..24b89cd2b692 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -72,7 +72,8 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct 
cedrus_ctx *ctx)
        ctrl_size = sizeof(ctrl) * CEDRUS_CONTROLS_COUNT + 1;
 
        ctx->ctrls = kzalloc(ctrl_size, GFP_KERNEL);
-       memset(ctx->ctrls, 0, ctrl_size);
+       if (!ctx->ctrls)
+               return -ENOMEM;
 
        for (i = 0; i < CEDRUS_CONTROLS_COUNT; i++) {
                struct v4l2_ctrl_config cfg = { NULL };
-- 
2.19.2

Reply via email to