This driver doesn't set all members of mbus format field when the
VIDIOC_SUBDEV_{S,G}_FMT ioctls are called.

This is detected by v4l2-compliance.

Cc: Guennadi Liakhovetski <g.liakhovet...@gmx.de>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com>
---
* No changes from v1

 drivers/media/i2c/mt9m001.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/media/i2c/mt9m001.c b/drivers/media/i2c/mt9m001.c
index f97ab48..61e5e6f 100644
--- a/drivers/media/i2c/mt9m001.c
+++ b/drivers/media/i2c/mt9m001.c
@@ -340,6 +340,9 @@ static int mt9m001_get_fmt(struct v4l2_subdev *sd,
        mf->code        = mt9m001->fmt->code;
        mf->colorspace  = mt9m001->fmt->colorspace;
        mf->field       = V4L2_FIELD_NONE;
+       mf->ycbcr_enc   = V4L2_YCBCR_ENC_DEFAULT;
+       mf->quantization = V4L2_QUANTIZATION_DEFAULT;
+       mf->xfer_func   = V4L2_XFER_FUNC_DEFAULT;
 
        return 0;
 }
@@ -400,6 +403,10 @@ static int mt9m001_set_fmt(struct v4l2_subdev *sd,
        }
 
        mf->colorspace  = fmt->colorspace;
+       mf->field       = V4L2_FIELD_NONE;
+       mf->ycbcr_enc   = V4L2_YCBCR_ENC_DEFAULT;
+       mf->quantization = V4L2_QUANTIZATION_DEFAULT;
+       mf->xfer_func   = V4L2_XFER_FUNC_DEFAULT;
 
        if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
                return mt9m001_s_fmt(sd, fmt, mf);
-- 
2.7.4

Reply via email to