Hi Hans,

Thank you for the patch.

On Thu, Feb 21, 2019 at 03:21:42PM +0100, Hans Verkuil wrote:
> The cec chardev kobject has no name, which made it hard to
> debug when kobject debugging is turned on.
> 
> Signed-off-by: Hans Verkuil <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>  drivers/media/cec/cec-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/cec/cec-core.c b/drivers/media/cec/cec-core.c
> index cc875dabd765..f5d1578e256a 100644
> --- a/drivers/media/cec/cec-core.c
> +++ b/drivers/media/cec/cec-core.c
> @@ -126,6 +126,7 @@ static int __must_check cec_devnode_register(struct 
> cec_devnode *devnode,
>       /* Part 2: Initialize and register the character device */
>       cdev_init(&devnode->cdev, &cec_devnode_fops);
>       devnode->cdev.owner = owner;
> +     kobject_set_name(&devnode->cdev.kobj, "cec%d", devnode->minor);
>  
>       ret = cdev_device_add(&devnode->cdev, &devnode->dev);
>       if (ret) {

-- 
Regards,

Laurent Pinchart

Reply via email to