Hi, On Wed, 2019-03-06 at 13:13 -0800, Dafna Hirschfeld wrote: > From: Hans Verkuil <[email protected]> > > The cedrus stateless decoder requires the use of request, so > indicate this by setting requires_requests to 1. > > Signed-off-by: Hans Verkuil <[email protected]>
Note that this is true for now, but we might need to get rid of the flag when adding support for decoding JPEG, which may not require the request API. Acked-by: Paul Kocialkowski <[email protected]> Cheers, Paul > --- > drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > index b47854b3bce4..9673874ece10 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -536,6 +536,7 @@ int cedrus_queue_init(void *priv, struct vb2_queue > *src_vq, > src_vq->lock = &ctx->dev->dev_mutex; > src_vq->dev = ctx->dev->dev; > src_vq->supports_requests = true; > + src_vq->requires_requests = true; > > ret = vb2_queue_init(src_vq); > if (ret) -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
