Em Mon, 15 Jul 2019 18:06:43 -0300 Ezequiel Garcia <[email protected]> escreveu:
> videodev.ko and v4l2-common.ko driver are built under > the same conditions. Therefore, it doesn't make much sense > to split them in two different modules. > > Splitting v4l2-common to its own driver has done many > years ago: > > commit a9254475bbfbed5f0596d952c6a3c9806e19dd0b > Author: Mauro Carvalho Chehab <[email protected]> > Date: Tue Jan 29 18:32:35 2008 -0300 > > V4L/DVB (7115): Fix bug #9833: regression when compiling V4L without I2C > > Back then, the subsystem organization was different. > However, With the current organization, there is no issue > compiling V4L2 with I2C as y/m/n. > > Signed-off-by: Ezequiel Garcia <[email protected]> > --- > drivers/media/v4l2-core/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/v4l2-core/Makefile > b/drivers/media/v4l2-core/Makefile > index 4d42418e603e..8e2f52f7800b 100644 > --- a/drivers/media/v4l2-core/Makefile > +++ b/drivers/media/v4l2-core/Makefile > @@ -7,14 +7,13 @@ tuner-objs := tuner-core.o > > videodev-objs := v4l2-dev.o v4l2-ioctl.o v4l2-device.o v4l2-fh.o > \ > v4l2-event.o v4l2-ctrls.o v4l2-subdev.o v4l2-clk.o \ > - v4l2-async.o > + v4l2-async.o v4l2-common.o > videodev-$(CONFIG_COMPAT) += v4l2-compat-ioctl32.o > videodev-$(CONFIG_TRACEPOINTS) += v4l2-trace.o > videodev-$(CONFIG_MEDIA_CONTROLLER) += v4l2-mc.o > > obj-$(CONFIG_V4L2_FWNODE) += v4l2-fwnode.o > obj-$(CONFIG_VIDEO_V4L2) += videodev.o > -obj-$(CONFIG_VIDEO_V4L2) += v4l2-common.o > obj-$(CONFIG_VIDEO_V4L2) += v4l2-dv-timings.o > > obj-$(CONFIG_VIDEO_TUNER) += tuner.o Huh? This patch sounds incomplete... Where are you removing the MODULE_foo macros) from v4l2-common.c? Thanks, Mauro
