Hi Marco,
On Wed, Jun 19, 2019 at 05:28:37PM +0200, Marco Felsch wrote:
> Add corresponding dt-bindings for the Toshiba tc358746 device and update
> the MAINTAINERS file too.
>
> Signed-off-by: Marco Felsch <[email protected]>
> ---
> Hi Rob,
>
> I droped your reviewed-by tag since there where several changes.
>
> Changes
> v2:
> - use the Documentation/devicetree/bindings/media/ti,omap3isp.txt
> formatting scheme
> - Adapt introducing paragraph according Jacopo's comments
> - drop the clock-names property
> - drop the clock-lanes (csi-2) property
> - adapt the property descriptions accroding Jacopo's comments
> - use port@0 as input and port@1 as output port instead of mapping
> port@0 to parallel and port@1 to csi-2 interface
> - Adapt port/endpoint description according Jacopo's and Sakari's
> comments
> - Adapt the example
> - squash v1 patch-3 and patch-1
> - set status to Maintained
>
> .../bindings/media/i2c/toshiba,tc358746.txt | 95 +++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 102 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt
> b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt
> new file mode 100644
> index 000000000000..e79b45ee050e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt
> @@ -0,0 +1,95 @@
> +Toshiba TC358746 Parallel to MIPI CSI2-TX or MIPI CSI2-RX to Parallel Bridge
> +============================================================================
> +
> +The Toshiba TC358746 converts a parallel into a MIPI CSI-2 stream. The
> direction
> +can be either parallel-in -> csi-out e.g. to connect a parallel camera to a
> +MIPI CSI-2 host or csi-in -> parallel-out e.g. to connect a parallel display
> to
> +a MIPI CSI-2 host. It's programmable trough I2C and SPI. The SPI interface is
> +only supported in parallel-in -> csi-out mode.
> +
> +Required properties
> +-------------------
> +
> +- compatible : Shall be "toshiba,tc358746"
> +- reg : Shall be <0x0e>
> +- clocks : Phandle to the reference clock source
> +
> +Optional properties
> +-------------------
> +
> +- reset-gpios : Phandle to the GPIO connected to the reset
> input pin
> +
> +Port nodes (required)
> +=====================
> +
> +The device node must contain two ports children nodes which should be grouped
> +within a 'ports' node. The first port describes the input connection, the
> second
> +one describes the output one. Each port shall contain one endpoint subnode
> that
> +connects to a remote device and specifies the bus type of the input and
> output
> +ports. Only one endpoint per port shall be present.
> +
> +More documentation on these bindings is available in [1].
> +
> +reg : The interface:
> + 0 - Input, either parallel or MIPI CSI-2
> + 1 - Output, either parallel or MIPI CSI-2
> +
> +Endpoint nodes (required)
> +=========================
> +
> +Required properties
> +-------------------
> +
> +- bus-width : Look at [1] for more information (Parallel endpoint)
> +- data-lanes : Look at [1] for more information (CSI-2 endpoint)
Which values data-lanes may have? How about the bus-width property?
> +- link-frequencies : Array of frequencies the driver can choose to
> + full-fill the parallel timings calculation. Look at
> + [1] for more information (CSI-2 endpoint)
> +
> +Optional properties
> +-------------------
> +
> +- bus-type : Look at [1] for more information
I think you can omit this as you have either bus-width or data-lanes that
implicitly tell the type of the bus. Another possibility would be making
this required, but optional doesn't seem useful.
> +- clock-noncontinuous : Look at [1] for more information (CSI-2
> endpoint)
> +
> +[1] Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example
> +=======
> +
> +&i2c {
> + csi-bridge@0e {
> + reg = <0x0e>;
> + compatible = "toshiba,tc358746";
> + pinctrl-names = "default";
> + clocks = <&clk_cam_ref>;
> + reset-gpios = <&gpio3 2 GPIO_ACTIVE_LOW>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* Input */
> + port@0 {
> + reg = <0>;
> +
> + tc358746_parallel_in: endpoint {
> + bus-width = <8>;
> + remote-endpoint =
> <µn_parallel_out>;
> + };
> + };
> +
> + /* Output */
> + port@1 {
> + reg = <1>;
> +
> + tc358746_mipi2_out: endpoint {
> + remote-endpoint = <&mipi_csi2_in>;
> + data-lanes = <1 2>;
> + clock-noncontinuous;
> + link-frequencies = /bits/ 64
> <216000000>;
> + };
> + };
> + };
> + };
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 57f496cff999..833b3c8fb301 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15955,6 +15955,13 @@ S: Maintained
> F: drivers/media/i2c/tc358743*
> F: include/media/i2c/tc358743.h
>
> +TOSHIBA TC358746 DRIVER
> +M: Marco Felsch <[email protected]>
> +L: [email protected]
> +S: Maintained
> +F: drivers/media/i2c/tc358746*
> +F: Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt
> +
> TOSHIBA WMI HOTKEYS DRIVER
> M: Azael Avalos <[email protected]>
> L: [email protected]
--
Kind regards,
Sakari Ailus
[email protected]
