Hi Oliver,
Oliver Endriss wrote:
> Mauro,
>
> Please pull from http://[email protected]/hg/~endriss/ngene
It were not an easy to work on this changeset, since it hit a bug at gentree.pl
script.
Basically, this drivers use #elseif directive instead of #elif, making
gentree.pl to
die, and generating broken converted patches. It took some time to discover and
fix
the bug.
Anyway, I've applied the converted patches on a temporary git tree:
http://git.linuxtv.org/mchehab/ngene.git
Please double check if everything is ok there.
I had to add a hack at one of the patches, due to the frontend incompatibilities
at stv090x, starting on this changeset:
Author: Matthias Benesch <[email protected]>
Date: Sat Dec 19 12:48:22 2009 -0300
V4L/DVB: ngene: Added Media-Pointer MP-S2/CineS2 DVB-S2 Twin Tuner
The hack were removed on this one:
Author: Oliver Endriss <[email protected]>
Date: Mon Feb 1 22:01:31 2010 -0300
V4L/DVB: ngene: Adapt to current frontend drivers
After applying all the patches, I'm getting this error:
drivers/media/dvb/ngene/ngene-core.c: In function ‘ngene_i2c_init’:
drivers/media/dvb/ngene/ngene-core.c:860: warning: passing argument 1 of
‘__mutex_init’ from incompatible pointer type
On this line:
mutex_init(&adap->bus_lock);
The final diff also hit a few troubles at the driver, as pointed by
checkpatch.pl:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#113: FILE: drivers/media/dvb/ngene/ngene-core.c:35:
+#include <asm/io.h>
WARNING: line over 80 characters
#348: FILE: drivers/media/dvb/ngene/ngene-core.c:270:
+ HOST_TO_NGENE, buf[0], buf[1], buf[2], buf[3], buf[4], buf[5],
buf[6], buf[7]);
WARNING: line over 80 characters
#352: FILE: drivers/media/dvb/ngene/ngene-core.c:274:
+ NGENE_TO_HOST, buf[0], buf[1], buf[2], buf[3], buf[4], buf[5],
buf[6], buf[7]);
ERROR: that open brace { should be on the previous line
#1693: FILE: drivers/media/dvb/ngene/ngene-core.c:1615:
+ u8 tsin4_config[6] =
+ {3072 / 64, 3072 / 64, 0, 3072 / 64, 3072 / 64, 0};
ERROR: that open brace { should be on the previous line
#1695: FILE: drivers/media/dvb/ngene/ngene-core.c:1617:
+ u8 default_config[6] =
+ {4096 / 64, 4096 / 64, 0, 2048 / 64, 2048 / 64, 0};
WARNING: Use #include <linux/scatterlist.h> instead of <asm/scatterlist.h>
#2142: FILE: drivers/media/dvb/ngene/ngene.h:32:
+#include <asm/scatterlist.h>
WARNING: do not add new typedefs
#2313: FILE: drivers/media/dvb/ngene/ngene.h:203:
+typedef struct EVENT_BUFFER *PEVENT_BUFFER;
WARNING: do not add new typedefs
#2601: FILE: drivers/media/dvb/ngene/ngene.h:491:
+typedef struct HW_SCATTER_GATHER_ELEMENT *PHW_SCATTER_GATHER_ELEMENT;
WARNING: do not add new typedefs
#2602: FILE: drivers/media/dvb/ngene/ngene.h:492:
+typedef struct FWRB *PFWRB;
WARNING: do not add new typedefs
#2667: FILE: drivers/media/dvb/ngene/ngene.h:557:
+typedef struct {
total: 2 errors, 8 warnings, 2935 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
The two 80 col warnings and the two errors don't seem relevant, but please fix
the other warnings.
As usual, after receiving your fixes for the above, I'll review the driver
manually.
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
