Just one tiny comment: On Monday 22 February 2010 16:51:36 Sakari Ailus wrote: > Add support for event handling to do_ioctl. > > Signed-off-by: Sakari Ailus <sakari.ai...@maxwell.research.nokia.com> > --- > drivers/media/video/v4l2-fh.c | 5 +++- > drivers/media/video/v4l2-ioctl.c | 50 > ++++++++++++++++++++++++++++++++++++++ > include/media/v4l2-ioctl.h | 7 +++++ > 3 files changed, 61 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/v4l2-fh.c b/drivers/media/video/v4l2-fh.c > index 713f5a0..2986a2c 100644 > --- a/drivers/media/video/v4l2-fh.c > +++ b/drivers/media/video/v4l2-fh.c > @@ -33,7 +33,10 @@ void v4l2_fh_init(struct v4l2_fh *fh, struct video_device > *vdev) > fh->vdev = vdev; > INIT_LIST_HEAD(&fh->list); > set_bit(V4L2_FL_USES_V4L2_FH, &fh->vdev->flags); > - v4l2_event_init(fh);
I recommend adding a small comment here along the lines of: /* fh->events only needs to be initialized if the driver supports the VIDIOC_SUBSCRIBE_EVENT ioctl. */ > + if (vdev->ioctl_ops && vdev->ioctl_ops->vidioc_subscribe_event) > + v4l2_event_init(fh); > + else > + fh->events = NULL; > } > EXPORT_SYMBOL_GPL(v4l2_fh_init); > Other than that: Reviewed-by: Hans Verkuil <hverk...@xs4all.nl> -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
