Hi Justin, On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote: > On 06/14/2010 01:53 PM, Jean Delvare wrote: > > Hi Justin, > > > > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: > >> could be a right solution, could be wrong > >> here is the warning: > >> CC drivers/i2c/i2c-core.o > >> drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': > >> drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used > >> > >> Signed-off-by: Justin P. Mattock<justinmatt...@gmail.com> > >> > >> --- > >> drivers/i2c/i2c-core.c | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > >> index 1cca263..79c6c26 100644 > >> --- a/drivers/i2c/i2c-core.c > >> +++ b/drivers/i2c/i2c-core.c > >> @@ -794,6 +794,8 @@ static int i2c_register_adapter(struct i2c_adapter > >> *adap) > >> mutex_lock(&core_lock); > >> dummy = bus_for_each_drv(&i2c_bus_type, NULL, adap, > >> __process_new_adapter); > >> + if(!dummy) > >> + dummy = 0; > > > > One word: scripts/checkpatch.pl > > it was this, and/or just take the code out > (since I'm a newbie)
I was not (yet) arguing on the code itself, but on its format. Any patch you send should pass the formatting tests performed by scripts/checkpatch.pl. Thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
