On Fri, 27 Aug 2010, Michael Grzeschik wrote: > On Fri, Aug 27, 2010 at 05:11:18PM +0200, Guennadi Liakhovetski wrote: > > On Tue, 3 Aug 2010, Michael Grzeschik wrote: > > > > > Signed-off-by: Philipp Wiesner <p.wies...@phytec.de> > > > Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> > > > > I don't see these being used in any of your patches... > Yes, these are not used. They are a left over from the previous patchstack. > But they are checked against the datasheet and are correct. > Is it a problem to take them anyway?
It is not a problem, it is unneeded. You do not want to add all registers and all their fields to every driver, do you? There are some drivers in the kernel, that define more registers, than are used. Of course, say, if you use bits 0, 1, 2, and 4 of a register, you might as well define bit 3 - especially, if they are logically related. But this patch adds a whole family of parameters, none of which is used, so, I personally would avoid that. Thanks Guennadi > > Thanks, > Michael > > > > --- > > > drivers/media/video/mt9m111.c | 6 ++++++ > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c > > > index 8c076e5..1b21522 100644 > > > --- a/drivers/media/video/mt9m111.c > > > +++ b/drivers/media/video/mt9m111.c > > > @@ -63,6 +63,12 @@ > > > #define MT9M111_RESET_RESTART_FRAME (1 << 1) > > > #define MT9M111_RESET_RESET_MODE (1 << 0) > > > > > > +#define MT9M111_RM_FULL_POWER_RD (0 << 10) > > > +#define MT9M111_RM_LOW_POWER_RD (1 << 10) > > > +#define MT9M111_RM_COL_SKIP_4X (1 << 5) > > > +#define MT9M111_RM_ROW_SKIP_4X (1 << 4) > > > +#define MT9M111_RM_COL_SKIP_2X (1 << 3) > > > +#define MT9M111_RM_ROW_SKIP_2X (1 << 2) > > > #define MT9M111_RMB_MIRROR_COLS (1 << 1) > > > #define MT9M111_RMB_MIRROR_ROWS (1 << 0) > > > #define MT9M111_CTXT_CTRL_RESTART (1 << 15) > > > -- > > > 1.7.1 > > > > > > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
