On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky <maximlevit...@gmail.com> wrote: > The logic in ir_timer_keyup was inverted. > > In case that values aren't equal, > the meaning of the time_is_after_eq_jiffies(ir->keyup_jiffies) is that > ir->keyup_jiffies is after the the jiffies or equally that > that jiffies are before the the ir->keyup_jiffies which is > exactly the situation we want to avoid (that the timeout is in the future) > Confusing Eh?
Yeah, seen time_is_{before,after}_jiffies use accidentally inverted a couple of times... Kinda hints that we could use better names and/or descriptions of the functions, but maybe people just need to read more carefully (dunno, haven't looked to see what's there for usage descriptions already)... Anyway. > Signed-off-by: Maxim Levitsky <maximlevit...@gmail.com> > --- > drivers/media/IR/ir-keytable.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html