On Thursday, September 30, 2010 13:50:00 Mauro Carvalho Chehab wrote:
> This is an automatic generated email to let you know that the following patch
> were queued at the
> http://git.linuxtv.org/media-tree.git tree:
>
> Subject: V4L/DVB: V4L2: add a generic function to find the nearest discrete
> format to the required one
> Author: Guennadi Liakhovetski <[email protected]>
> Date: Fri Aug 27 13:41:44 2010 -0300
>
> Many video drivers implement a fixed set of frame formats and thus face a task
> of finding the best match for a user-requested format. Implementing this in a
> generic function has also an advantage, that different drivers with similar
> supported format sets will select the same format for the user, which improves
> consistency across drivers.
>
> Signed-off-by: Guennadi Liakhovetski <[email protected]>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> drivers/media/video/v4l2-common.c | 24 ++++++++++++++++++++++++
> include/linux/videodev2.h | 8 ++++++++
> 2 files changed, 32 insertions(+), 0 deletions(-)
<snip>
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index b06479f..957d5b0 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -397,6 +397,14 @@ struct v4l2_frmsize_discrete {
> __u32 height; /* Frame height [pixel] */
> };
>
> +struct v4l2_discrete_probe {
> + const struct v4l2_frmsize_discrete *sizes;
> + int num_sizes;
> +};
> +
> +struct v4l2_frmsize_discrete *v4l2_find_nearest_format(struct
> v4l2_discrete_probe *probe,
> + s32 width, s32 height);
> +
> struct v4l2_frmsize_stepwise {
> __u32 min_width; /* Minimum frame width [pixel]
> */
> __u32 max_width; /* Maximum frame width [pixel]
> */
??? What is this doing in videodev2.h? This belongs in v4l2-common.h!
Both the return pointer and the probe pointer can be const as well.
I'll make a patch for this since I've forgotten to adjust several
videobuf_queue_*_init
functions as well in my bkl patch :-(
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
