> -----Original Message-----
> From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> ow...@vger.kernel.org] On Behalf Of Aguirre, Sergio
> Sent: Tuesday, October 05, 2010 9:40 PM
> To: Laurent Pinchart; linux-media@vger.kernel.org
> Cc: sakari.ai...@maxwell.research.nokia.com
> Subject: RE: [RFC/PATCH v2 5/6] omap3: Export omap3isp platform device
> structure
>
> Hi Laurent,
>
> > -----Original Message-----
> > From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> > ow...@vger.kernel.org] On Behalf Of Laurent Pinchart
> > Sent: Tuesday, October 05, 2010 8:19 AM
> > To: linux-media@vger.kernel.org
> > Cc: sakari.ai...@maxwell.research.nokia.com
> > Subject: [RFC/PATCH v2 5/6] omap3: Export omap3isp platform device
> > structure
> >
> > From: Stanimir Varbanov <svarba...@mm-sol.com>
> >
> > The omap3isp platform device requires platform data. As the data can be
> > provided by a kernel module, the device can't be registered during arch
> > initialization.
> >
> > Remove the omap3isp platform device registration from
> > omap_init_camera(), and export the platform device structure to let
> > board code register/unregister it.
> >
>
> This patch needs to go through linux-omap ML.
[Hiremath, Vaibhav] Yes that's correct, all arch/arm/mach-omap2 and
arch/arm/plat-omap/ changes supposed to get reviewed from linux-omap mailing
list.
Thanks,
Vaibhav
>
> Regards,
> Sergio
>
> > Signed-off-by: Stanimir Varbanov <svarba...@mm-sol.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> > ---
> > arch/arm/mach-omap2/devices.c | 18 ++++++++++++++++--
> > arch/arm/mach-omap2/devices.h | 17 +++++++++++++++++
> > 2 files changed, 33 insertions(+), 2 deletions(-)
> > create mode 100644 arch/arm/mach-omap2/devices.h
> >
> > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-
> omap2/devices.c
> > index ade8db0..f9bc507 100644
> > --- a/arch/arm/mach-omap2/devices.c
> > +++ b/arch/arm/mach-omap2/devices.c
> > @@ -31,6 +31,8 @@
> >
> > #include "mux.h"
> >
> > +#include "devices.h"
> > +
> > #if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE)
> >
> > static struct resource cam_resources[] = {
> > @@ -141,16 +143,28 @@ static struct resource omap3isp_resources[] = {
> > }
> > };
> >
> > -static struct platform_device omap3isp_device = {
> > +static void omap3isp_release(struct device *dev)
> > +{
> > + /* Zero the device structure to avoid re-initialization complaints
> > from
> > + * kobject when the device will be re-registered.
> > + */
> > + memset(dev, 0, sizeof(*dev));
> > + dev->release = omap3isp_release;
> > +}
> > +
> > +struct platform_device omap3isp_device = {
> > .name = "omap3isp",
> > .id = -1,
> > .num_resources = ARRAY_SIZE(omap3isp_resources),
> > .resource = omap3isp_resources,
> > + .dev = {
> > + .release = omap3isp_release,
> > + },
> > };
> > +EXPORT_SYMBOL_GPL(omap3isp_device);
> >
> > static inline void omap_init_camera(void)
> > {
> > - platform_device_register(&omap3isp_device);
> > }
> > #else
> > static inline void omap_init_camera(void)
> > diff --git a/arch/arm/mach-omap2/devices.h b/arch/arm/mach-
> omap2/devices.h
> > new file mode 100644
> > index 0000000..f312d49
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/devices.h
> > @@ -0,0 +1,17 @@
> > +/*
> > + * arch/arm/mach-omap2/devices.h
> > + *
> > + * OMAP2 platform device setup/initialization
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +
> > +#ifndef __ARCH_ARM_MACH_OMAP_DEVICES_H
> > +#define __ARCH_ARM_MACH_OMAP_DEVICES_H
> > +
> > +extern struct platform_device omap3isp_device;
> > +
> > +#endif
> > --
> > 1.7.2.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media"
> in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
