Hi, Hiremath, Vaibhav wrote: >> -----Original Message----- >> From: Taneja, Archit >> Sent: Monday, September 27, 2010 12:47 PM >> To: Hiremath, Vaibhav >> Cc: linux-o...@vger.kernel.org; > linux-media@vger.kernel.org; Taneja, >> Archit >> Subject: [PATCH v2 0/2] V4L/DVB: OMAP_VOUT: Allow omap_vout to build without >> VRFB >> >> This lets omap_vout driver build and run without VRFB. It works along >> the lines of the following patch series: >> >> OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB >> https://patchwork.kernel.org/patch/105371/ >> >> Since VRFB is tightly coupled with the omap_vout driver, a handful of > vrfb specific functions have been defined and placed in omap_vout_vrfb.c >> >> A variable rotation_type is introduced in omapvideo_info like the way >> in omapfb_info, this allows to call vrfb specific functions only if >> the rotation type is vrfb. When the rotation_type is set to SDMA, the >> S_CTRL ioctl prevents the user setting a non zero rotation value. >> > [Hiremath, Vaibhav] Lets make one stand here, > > I think this series still doesn't support DMA based rotation, > unlike Fbdev driver so I would say lets clearly state that we > are not supporting sDMA based rotation here. So I don't see any reason why we > need
Yes, we aren't supporting sDMA rotation. I use the rotation_type to differentiate between using vrfb and not using vrfb. I agree it becomes misleading as it looks as if we support sDMA rotation, but im not sure how to differentiate between choosing vrfb and non-vrfb modes without using the enum "omap_dss_rotation_type". Should we add something like "OMAP_DSS_ROT_NONE" to the enum to show we won't do rotation, or should we add a new enum like omap_dss_buffer_type? The approach of patch is to allow us to set both types of rotation..but return an error if we try to set the rotation when the rotation type selected is sDMA. Can you suggest a cleaner way to choose between vrfb and non vrfb? > >> Archit Taneja (2): >> V4L/DVB: OMAP_VOUT: Create a seperate vrfb functions library >> V4L/DVB: OMAP_VOUT: Use rotation_type to choose between vrfb and sdram >> buffers >> >> drivers/media/video/omap/Kconfig | 1 - >> drivers/media/video/omap/Makefile | 1 + >> drivers/media/video/omap/omap_vout.c | 480 ++++++------------------ >> ----- drivers/media/video/omap/omap_vout_vrfb.c | 417 >> +++++++++++++++++++++++++ >> drivers/media/video/omap/omap_vout_vrfb.h | 40 +++ >> drivers/media/video/omap/omap_voutdef.h | 26 ++ >> 6 files changed, 571 insertions(+), 394 deletions(-) create mode >> 100644 drivers/media/video/omap/omap_vout_vrfb.c >> create mode 100644 drivers/media/video/omap/omap_vout_vrfb.h -- >> Version 2: >> - Don't try to enable SDRAM rotation , return an error if non zero rotation >> is attempted when rotation_type is set to SDMA rotation. Version 1: >> >> > http://www.mail-archive.com/linux-media@vger.kernel.org/msg21937.html-- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
