Hi Mauro, On Thursday 07 October 2010 03:56:47 Mauro Carvalho Chehab wrote: > drivers/media/video/videobuf-dma-sg.c: In function ‘videobuf_pages_to_sg’: > drivers/media/video/videobuf-dma-sg.c:119: warning: comparison of distinct > pointer types lacks a cast drivers/media/video/videobuf-dma-sg.c:120: > warning: comparison of distinct pointer types lacks a cast > > Signed-off-by: Mauro Carvalho Chehab <[email protected]> > > diff --git a/drivers/media/video/videobuf-dma-sg.c > b/drivers/media/video/videobuf-dma-sg.c index 359f2f3..7153e44 100644 > --- a/drivers/media/video/videobuf-dma-sg.c > +++ b/drivers/media/video/videobuf-dma-sg.c > @@ -116,8 +116,8 @@ static struct scatterlist *videobuf_pages_to_sg(struct > page **pages, goto nopage; > if (PageHighMem(pages[i])) > goto highmem; > - sg_set_page(&sglist[i], pages[i], min(PAGE_SIZE, size), 0); > - size -= min(PAGE_SIZE, size); > + sg_set_page(&sglist[i], pages[i], min((unsigned)PAGE_SIZE, > size), 0); > + size -= min((unsigned)PAGE_SIZE, size);
I think min_t(size_t, PAGE_SIZE, size) is the preferred way. > } > return sglist; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
