Hi > On Wed, Oct 13, 2010 at 5:30 PM, Dmitri Belimov <d.beli...@gmail.com> > wrote: > > Hi > > > > Our TV card Behold X7 has two different RF input. This RF inputs > > can switch between different RF sources. > > > > ANT 1 for analog and digital TV > > ANT 2 for FM radio > > > > The switch controlled by zl10353. > > > > I add some defines for the tuner xc5000 and use tuner callback to > > saa7134 part. All works well. But my patch can touch other TV cards > > with xc5000. > > > > Devin can you check my changes on the other TV cards. > > > > With my best regards, Dmitry. > > Hello Dmitri, > > I've looked at the patch. I really don't think this is the right > approach. The tuner driver should not have any of this logic - it > should be in the bridge driver. You can also look at Michael Krufky's > frontend override patches, which allow the bridge to intervene when > DVB frontend commands are made (for example, to toggle the antenna > before the tune is performed).
Ok. > I understand the problem you are trying to solve, but jamming the > logic into the tuner driver really is a bad idea. > > NACK. > > Devin > > -- > Devin J. Heitmueller - Kernel Labs > http://www.kernellabs.com Ok. With my best regards, Dmitry. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
