>Thank you for your reply about my comments. >Refer to as below. Hi,
>> >> I don't know if this is necessary. MFC_NUM_CONTEXTS can be fixed at >> the maximum number allowed by MFC hw: 16. I highly doubt someone will >> open that many contexts. Increasing this number will not significantly >> increase storage space used by MFC if no contexts are used. It will >> only change size of one pointer array ( struct s5p_mfc_ctx >> *ctx[MFC_NUM_CONTEXTS]; ). >> >In many project, user can open many contexts according to the scenario >of not only phone but also netbook, tablet. 'cause MFC supports multiple >instance. That's why I suggested this param. be configurable. I see no problem with setting it to the maximum number allowed by MFC - 16. There would be no use of setting a smaller value. Except a _minimal_ saving of memory. >> > >> > > + >> > > +/* Check whether a context should be run on hardware */ int >> > > +s5p_mfc_ctx_ready(struct s5p_mfc_ctx *ctx) { >> > > + mfc_debug("s5p_mfc_ctx_ready: src=%d, dst=%d, state=%d\n", >> > > + ctx->src_queue_cnt, ctx->dst_queue_cnt, ctx->state); >> > > + /* Context is to parse header */ >> > > + if (ctx->src_queue_cnt >= 1 && ctx->state == >> > MFCINST_DEC_GOT_INST) >> > > + return 1; >> > > + /* Context is to decode a frame */ >> > > + if (ctx->src_queue_cnt >= 1 && ctx->state == MFCINST_DEC_RUNNING >> > && >> > > + ctx->dst_queue_cnt >= ctx- -- Kamil Debski Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html