On Fri, Nov 12, 2010 at 10:56:34AM -0200, Mauro Carvalho Chehab wrote: >Em 12-11-2010 10:12, David Härdeman escreveu: >> Shouldn't platform_data be const? And you'll break the refcounting >> done in rc_allocate_device() and rc_free_device() / >> rc_unregister_device(). Not to mention the silent bugs that may be >> introduced if anyone modifies rc_allocate_device() without noticing >> that one driver isn't using it. > >It will still be const. platform_data will pass a pointer to some struct. >The value of the pointer won't change. I don't see why this would break >refcounting, as what will happen is that the caller driver will call >rc_allocate_device() and fill some fields there, instead of ir_kbd_i2c.
I think I've misunderstood what you've been proposing for ir_kbd_i2c. That sounds like a good solution. >I'm working on a patch for it right now. Good, I'll just wait until the patches are available to comment :) -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
