On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote: > On 12/31/2010 10:48 PM, Finn Thain wrote: > >>-/* BIT[8-9] is for SW Antenna Diversity. Only the value > >>EEPROM_SW_AD_ENABLE means enable, other values are diable. > >> */ > >>+/* BIT[8-9] is for SW Antenna Diversity. Only the value > >>EEPROM_SW_AD_ENABLE means enable, other values are disabled. > >> */ > > > >I think, "other values disable" was what you meant? > > > >Finn > > > >> #define EEPROM_SW_AD_MASK 0x0300 > >> #define EEPROM_SW_AD_ENABLE 0x0100 > >> > >> > > > > no! I changed it to disabled to make it proper..
Finn is obviously right, but maybe a compromise would be: Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean "disable". regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
