Em 12-01-2011 08:25, Marek Szyprowski escreveu:
> Hello Mauro,
> 
> I've rebased our fimc and saa patches onto 
> http://linuxtv.org/git/mchehab/experimental.git
> vb2_test branch.

Thanks!

As before, I'll be commenting the patches as I'll be seeing any issues.

> Pawel Osciak (2):
>       Fix mmap() example in the V4L2 API DocBook

In fact, the check for retval < 0 instead of retval == -1 is not a fix. 
According with
mmap man pages:
        RETURN VALUE
               On  success,  mmap() returns a pointer to the mapped area.  On 
error, the value MAP_FAILED (that is, (void *) -1) is returned, and errno
               is set appropriately.  On success, munmap() returns 0, on 
failure -1, and errno is set (probably to EINVAL).

The change is not wrong, as -1 is lower than 0, but using -1 is more compliant 
with
libc. So, I'll be applying just the CodingStyle fixes on it.

Cheers,
mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to