Em 13-01-2011 14:30, Jean-Francois Moine escreveu:
> On Thu, 13 Jan 2011 12:38:04 +0100
> Antonio Ospite <osp...@studenti.unina.it> wrote:
> 
>>> Jean-François Moine (9):  
>> [...]
>>>       gspca - ov534: Use the new video control mechanism  
>>
>> In this commit, is there a reason why you didn't rename also
>> sd_setagc() into setagc() like for the other functions?
>>
>> I am going to test the changes and report back if there's anything
>> more, I like the cleanup tho.
> 
> Hi Antonio,
> 
> With the new video control mechanism, the '.set_control' function is
> called only when capture is active. Otherwise, the '.set' function is
> called in any case, and here, it activates/inactivates the auto white
> balance control... Oh, I forgot to disable the awb when the agc is
> disabled!
> 
> Thank you for reporting any problem. BTW, the webcam 06f8:3002 which
> had been removed some time ago is being tested. I will add it to this
> subdriver as soon as it works correctly.

I'm applying the remaining 8 patches from this series, as they seem to be ok.

Please send me a new pull request when you fix the issues with the ov534 new
video control mechanism.

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to