On Sun, Feb 20, 2011 at 10:47 AM, Hans Verkuil <hverk...@xs4all.nl> wrote: > Hi David,
Hi Hans, > > On Saturday, February 19, 2011 17:35:46 David Cohen wrote: >> Hi, >> >> This is the first patch (set) version to remove V4L2 internal device >> interface. >> I have converted tcm825x VGA sensor to V4L2 sub device interface. I removed >> also some workarounds in the driver which doesn't fit anymore in its new >> interface. > > Very nice! It looks good. I noticed that you didn't convert it to the control > framework yet, but after looking at the controls I think that it is probably > better if I do that anyway. There are several private controls in this driver, > and I will need to take a good look at those. Yes, to port to control fw is not part of this task yet. IMO there are plenty of missing tasks to let the driver in a good shape and it may need a very good rework. For now I'm focusing in remove v4l2 internal interface. > >> TODO: >> - Remove V4L2 int device interface from omap24xxcam driver. >> - Define a new interface to handle xclk. OMAP3 ISP could be used as base. >> - Use some base platform (probably N8X0) to add board code and test them. >> - Remove V4L2 int device. :) > > It would be so nice to have that API removed :-) Yes. :) Br, David > > Regards, > > Hans > >> >> Br, >> >> David >> --- >> >> David Cohen (1): >> tcm825x: convert driver to V4L2 sub device interface >> >> drivers/media/video/tcm825x.c | 369 >> ++++++++++++----------------------------- >> drivers/media/video/tcm825x.h | 6 +- >> 2 files changed, 109 insertions(+), 266 deletions(-) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > > -- > Hans Verkuil - video4linux developer - sponsored by Cisco > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
