Hello Marko,
On 03/26/2011 09:20 PM, Marko Ristola wrote:
> Following patch has been tested enough since last Summer 2010:
>
> "Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function"
> https://patchwork.kernel.org/patch/118147/
> It modifies both dvb_dmx_swfilter_204() and dvb_dmx_swfilter() functions.
sorry, I didn't know about your patch. Can you please resubmit it with
the following changes?
- Don't use camelCase (findNextPacket)
- Remove disabled printk() calls.
- Only one statement per line.
if (unlikely(lost = pos - start)) {
while (likely((p = findNextPacket(buf, p, count, pktsize)) < count)) {
- Add white space between while and the opening brace.
while(likely(pos < count)) {
- Use unsigned data types for pos and pktsize:
static inline int findNextPacket(const u8 *buf, int pos, size_t count,
const int pktsize)
The CodingStyle[1] document can serve as a guideline on how to properly
format kernel code.
Does the excessive use of likely() and unlikely() really improve the
performance or is it just a guess?
Regards,
Andreas
[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/CodingStyle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
