On Monday 2 May 2011, Mauro Carvalho Chehab <mche...@redhat.com> wrote: > Em 02-05-2011 16:11, Hans Verkuil escreveu: > > NACK. > > > > For two reasons: first of all it is not signed off by Andy Walls, the > > cx18 maintainer. I know he has had other things on his plate recently > > which is probably why he hasn't had the chance to review this. > > > > Secondly, while doing a quick scan myself I noticed that this code does a > > conversion from UYVY format to YUYV *in the driver*. Format conversion is > > not allowed in the kernel, we have libv4lconvert for that. So at the > > minimum this conversion code must be removed first. > > Patch is there at the ML since Apr, 6 and nobody acked/nacked it. If you or > andy were against it, why none of you commented it there? > > Now that the patch were committed, I won't revert it without a very good > reason. > > With respect to the "conversion from UYVY format to YUYV", a simple patch > could fix it, instead of removing the entire patchset. > > Steven/Simon, > could you please work on such change? > I received feedback, which I've been working on, and have converted to a new patch against the baseline tree without this patch applied. I can obviously rebase (thanks, git!) so that it applies on top of this patch. It massively cleans up the code, fixes a bug, and removes the in-kernel format conversion (we use libv4l here anyway, so it's not needed)
I have one more work item, requested by Andy and Hans, and that's to convert just the YUV capture from videobuf to vb2, so that when Andy's got spare time again, it'll be easier for him to convert the whole driver. I've been delayed on this by other work committments, but I do have this on my schedule. How do you want me to proceed? -- Simon Farnsworth Software Engineer ONELAN Limited http://www.onelan.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
