On Tue, 5 Jul 2011, JAIN, AMBER wrote:
> > > diff --git a/drivers/media/video/omap24xxcam.c
> > b/drivers/media/video/omap24xxcam.c
> > > index f6626e8..d92d4c6 100644
> > > --- a/drivers/media/video/omap24xxcam.c
> > > +++ b/drivers/media/video/omap24xxcam.c
> > > @@ -309,11 +309,11 @@ static int
> > omap24xxcam_vbq_alloc_mmap_buffer(struct videobuf_buffer *vb)
> > > order--;
> > >
> > > /* try to allocate as many contiguous pages as possible */
> > > - page = alloc_pages(GFP_KERNEL | GFP_DMA, order);
> > > + page = alloc_pages(GFP_KERNEL, order);
> > > /* if allocation fails, try to allocate smaller amount */
> > > while (page == NULL) {
> > > order--;
> > > - page = alloc_pages(GFP_KERNEL | GFP_DMA, order);
> > > + page = alloc_pages(GFP_KERNEL, order);
> > > if (page == NULL && !order) {
> > > err = -ENOMEM;
> > > goto out;
> >
> > Hmm... the proper fix wouldn't be to define ZONE_DMA at OMAP?
>
> I don't think so, my understanding for ZOME_DMA is that it is defined
> for architectures that have restrictions on memory addresses that can be
> used for DMA. OMAP doesn't have any such restriction and hence we should
> not define ZONE_DMA.
>
s/should not define/do not need to define/
Right, if omap does not have DMA restrictions then the GFP_DMA usage that
is removed with this patch was incorrect.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
