On 24.08.2011 19:54, Devin Heitmueller wrote: > On Wed, Aug 24, 2011 at 1:33 PM, Andreas Oberritter <o...@linuxtv.org> wrote: >> Signed-off-by: Andreas Oberritter <o...@linuxtv.org> > > This may seem like a silly question, but *why* are you making this > change? There is no explanation for what prompted it. Is it in > response to some issue you encountered?
A semaphore with only one unit is nothing but a mutex. Using a mutex structure decreases memory footprint and improves readability. > I'm asking because in general dvb_frontend has a fairly complicated > locking model, and unless there is a compelling reason to make changes > I would be against it. The lock is part of fepriv, which is local to dvb_frontend.c. The patch is really simple. > In other words, this is a bad place for arbitrary "cleanup patches". It's impossible to clean up dvb_frontend.c, which looks quite unmaintained, without touching it. Regards, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
