2011/9/1 Sakari Ailus <sakari.ai...@iki.fi>: > On Thu, Sep 01, 2011 at 11:14:08AM +0200, Sylwester Nawrocki wrote: >> Hi Sakari, >> >> On 09/01/2011 10:47 AM, Sakari Ailus wrote: >> > On Thu, Sep 01, 2011 at 09:15:20AM +0200, Guennadi Liakhovetski wrote: >> >> On Thu, 1 Sep 2011, Sakari Ailus wrote: >> >> >> >>> On Wed, Aug 31, 2011 at 03:27:49PM +0000, Bastian Hecht wrote: >> >>>> 2011/8/28 Laurent Pinchart <laurent.pinch...@ideasonboard.com>: >> >>> [clip] >> >>>>> If I'm not mistaken V4L2_CID_PRIVATE_BASE is deprecated. >> >>>> >> >>>> I checked at http://v4l2spec.bytesex.org/spec/x542.htm, googled >> >>>> "V4L2_CID_PRIVATE_BASE deprecated" and read >> >>>> Documentation/feature-removal-schedule.txt. I couldn't find anything. >> >>> >> >>> Hmm. Did you happen to check when that has been written? :) >> >>> >> >>> Please use this one instead: >> >>> >> >>> <URL:http://hverkuil.home.xs4all.nl/spec/media.html> >> >> >> >> "Drivers can also implement their own custom controls using >> >> V4L2_CID_PRIVATE_BASE and higher values." >> >> >> >> Which specific location describes V4L2_CID_PRIVATE_BASE differently there? >> > >> > That was a general comment, not related to the private base. There's no >> > use for a three-year-old spec as a reference! >> > >> > The control framework does not support private controls, for example. The >> > controls should be put to their own class in videodev2.h nowadays, that's >> > my >> > understanding. Cc Hans. >> >> Is this really the case that we close the door for private controls in >> the mainline kernel ? Or am I misunderstanding something ? >> How about v4l2_ctrl_new_custom() ? >> >> What if there are controls applicable to single driver only ? >> Do we really want to have plenty of such in videodev2.h ? > > We have some of those already in videodev2.h. I'm not certain if I'm happy > with this myself, considering e.g. that we could get a few truckloads of > only camera lens hardware specific controls in the near future.
So in my case (as these are controls that might be used by others too) I should add something like #define V4L2_CID_BLUE_SATURATION (V4L2_CID_CAMERA_CLASS_BASE+19) #define V4L2_CID_RED_SATURATION (V4L2_CID_CAMERA_CLASS_BASE+20) #define V4L2_CID_GRAY_SCALE_IMAGE (V4L2_CID_CAMERA_CLASS_BASE+21) #define V4L2_CID_SOLARIZE_EFFECT (V4L2_CID_CAMERA_CLASS_BASE+22) to videodev2.h? > -- > Sakari Ailus > sakari.ai...@iki.fi > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
