Hi Vaibhav, On Tue, Sep 27, 2011 at 12:09 PM, Hiremath, Vaibhav <hvaib...@ti.com> wrote: >> -----Original Message----- >> From: Semwal, Sumit >> Sent: Tuesday, September 27, 2011 11:12 AM >> To: Hiremath, Vaibhav >> Cc: Taneja, Archit; Valkeinen, Tomi; linux-o...@vger.kernel.org; linux- >> me...@vger.kernel.org >> Subject: Re: [PATCH 3/5] [media]: OMAP_VOUT: Fix VSYNC IRQ handling in >> omap_vout_isr >> >> Hi Vaibhav, <snip> >> >>> Archit, >> >>> >> >>> I think I am still not understood or convinced with your description >> above, >> >>> >> >>> The code snippet which we are referring here, does check whether the >> >>> interrupt is either VSYNC or VSYNC2, else fall back to "vout_isr_err". >> > >> > >> I am not quite sure I understand what is the confusing part here - >> below is my understanding; please correct me if you think otherwise. >> As I understand, this patch creates a (missing) correlation between a >> manager and the corresponding ISR. The earlier code would accept a >> VSYNC2 for LCD1 manager, which is not the correct thing to do. >> That is why the check of 'if ((mgr==LCD) && (IRQ==VSYNC))' kind of >> thing is needed; Which part of this do you think the above patch >> doesn't do? Or, do you think it is not needed / done correctly? > Sumit, > > Please look at the patch carefully, it does exactly same thing. I understand > the use-case what Archit explained in the last email but in this patch > context, the use-case change anything here in this patch. > > Can you review it carefully again? Thanks - I did review it carefully (the first time, and again), and maybe it is something that you're able to see which I can't.
Could you please explain why you think (1) if (!(irqstatus & (DISPC_IRQ_VSYNC | DISPC_IRQ_VSYNC2))) goto vout_isr_err; is *exactly* the same as (2) if (!((mgr==LCD) && (irqstatus & DISPC_IRQ_VSYNC)) || (mgr==LCD2) && (irqstatus & DISPC_IRQ_VSYNC2)) ) goto vout_isr_err; [which I understand is what Archit's patch does] I am not able to see any correlation in (1) between mgr and irq, whereas it is quite clear in (2). Let me know if I missed something? Best regards, ~Sumit. > > Thanks, > Vaibhav <snip> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html