Hi Sakari,
On Wednesday 26 October 2011 03:13:30 Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch. I have a single comment below.
>
> On Tue, Oct 18, 2011 at 11:14:56PM +0200, Laurent Pinchart wrote:
> > The macros that define the minimum/maximum input and output sizes are
> > defined in seperate files and have no consistent naming. In preparation
> > for preview engine cropping support, move them all to isppreview.c and
> > rename them to PREV_{MIN|MAX}_{IN|OUT}_{WIDTH|HEIGHT}*.
> >
> > Remove unused and/or unneeded local variables that store the maximum
> > output width.
> >
> > Signed-off-by: Laurent Pinchart <[email protected]>
> > ---
> >
> > drivers/media/video/omap3isp/isppreview.c | 33 ++++++++++++------------
> > drivers/media/video/omap3isp/ispreg.h | 3 --
> > 2 files changed, 17 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/media/video/omap3isp/isppreview.c
> > b/drivers/media/video/omap3isp/isppreview.c index c920c1e..d5cce42
> > 100644
> > --- a/drivers/media/video/omap3isp/isppreview.c
> > +++ b/drivers/media/video/omap3isp/isppreview.c
> > @@ -76,9 +76,15 @@ static struct omap3isp_prev_csc flr_prev_csc = {
> >
> > #define DEF_DETECT_CORRECT_VAL 0xe
> >
> > -#define PREV_MIN_WIDTH 64
> > -#define PREV_MIN_HEIGHT 8
> > -#define PREV_MAX_HEIGHT 16384
> > +#define PREV_MIN_IN_WIDTH 64
> > +#define PREV_MIN_IN_HEIGHT 8
> > +#define PREV_MAX_IN_HEIGHT 16384
> > +
> > +#define PREV_MIN_OUT_WIDTH 0
> > +#define PREV_MIN_OUT_HEIGHT 0
> > +#define PREV_MAX_OUT_WIDTH 1280
> > +#define PREV_MAX_OUT_WIDTH_ES2 3300
> > +#define PREV_MAX_OUT_WIDTH_3630 4096
>
> The preview line buffer size very probably depends on the ISP revision and
> not OMAP revision. I think this name is such for historical reasons.
>
> I just thought this now that you're changing them anyway. :)
As it seems I'll have to resubmit the patches to v3.3, I'll fix this. Thanks
for pointing it out.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
