Hi Hans,
I am not sure if I understand this right. You wrote:
"Comments are added on how to convert the legacy ioctls to standard V4L2 API
in applications. Perhaps these legacy ioctls in ivtv can even be removed in a
few years time."
But the patch looks for me as if the currently used ioctls shall be removed
now, which would immidiately break existing applications.
This is an example of the currently used code:
void cPvr350Device::DecoderStop(int blank)
{
struct video_command cmd;
memset(&cmd, 0, sizeof(cmd));
cmd.cmd = VIDEO_CMD_STOP;
if (blank) {
cmd.flags = VIDEO_CMD_STOP_TO_BLACK |
VIDEO_CMD_STOP_IMMEDIATELY;
} else { //show last frame instead of a black screen
cmd.flags = VIDEO_CMD_STOP_IMMEDIATELY;
}
if (IOCTL(fd_out, VIDEO_COMMAND, &cmd) < 0) {
log(pvrERROR, "pvr350: VIDEO_CMD_STOP %s error=%d:%s",
blank ? "(blank)" : "", errno, strerror(errno));
}
}
As far as I know my pvr350-Plugin for vdr is the only application which uses
the hardware decoder of the PVR350 (mythtv has dropped support some years
ago). There are only a few users left in time of HDTV.
I don't really understand why it is necessary to do this changes.
I suggest to increase the ivtv driver version number when implementing the
changes. The application (which must be backward compatible) should be able to
determine which ioctl it has to use.
It would be much better if the ivtv driver would continue to support the old
ioctl for the few years we still have any PVR350 user.
Greets,
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
