On 16 December 2011 09:47, Guennadi Liakhovetski <g.liakhovet...@gmx.de> wrote:
> Hi Javier
>
> On Fri, 16 Dec 2011, Javier Martin wrote:
>
>> Some v4l-subdevs such as tvp5150 have multiple
>> inputs. This patch allows the user of a soc-camera
>> device to select between them.
>
> Sure, we can support it. But I've got a couple of remarks:
>
> First question: you probably also want to patch soc_camera_g_input() and
> soc_camera_enum_input(). But no, I do not know how. The video subdevice
> operations do not seem to provide a way to query subdevice routing
> capabilities, so, I've got no idea how we're supposed to support
> enum_input(). There is a g_input_status() method, but I'm not sure about
> its semantics. Would it return an error like -EINVAL on an unsupported
> index?

I would gladly implement also eum_input() and get_input() but I can't
test it since my device does not support "g_input_status" callback but
only "s_routing".

> Secondly, I would prefer to keep the current behaviour per default. I.e.,
> if the subdevice doesn't implement routing- / input-related operations, we
> should act as before - assume input 0 and return success.

Sure, it seems reasonable.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to