Hi Fabio,
Thanks for the review.
On Sunday 26 February 2012 11:16:19 Fabio Estevam wrote:
> On Sun, Feb 26, 2012 at 12:27 AM, Laurent Pinchart wrote:
> > +static int __init mt9m032_init(void)
> > +{
> > + int rval;
> > +
> > + rval = i2c_add_driver(&mt9m032_i2c_driver);
> > + if (rval)
> > + pr_err("%s: failed registering " MT9M032_NAME "\n",
> > __func__); +
> > + return rval;
> > +}
> > +
> > +static void mt9m032_exit(void)
> > +{
> > + i2c_del_driver(&mt9m032_i2c_driver);
> > +}
> > +
> > +module_init(mt9m032_init);
> > +module_exit(mt9m032_exit);
>
> module_i2c_driver could be used here instead.
That's fixed by patch 4/11. As explained in the cover letter, patch 01/11 is
the original driver as submitted by Martin. I've decided not to change it to
make review easier. I can then squash some of the other patches onto this one
when pushing the set upstream.
> > +
> > +MODULE_AUTHOR("Martin Hostettler");
>
> E-mail address missing.
Good point. Martin, can I add your e-mail address here ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
