Hi Laurent,

Thanks for the comments.

Laurent Pinchart wrote:
Hi Sakari,

Thanks for the patch.

The code looks fine, but unfortunately breaks compilation when using kernel
headers<  v3.5 (which is a pretty common case as of today ;-)).

V4L2_CTRL_TYPE_INTEGER_MENU is an enumerated value, not a pre-processor
#define, so it's difficult to test for it using conditional compilation.

Maybe including a copy of videodev2.h in the yavta repository is the best
option ?

Yeah; I agree. The value of the enum item we could still #define but the addition of the union to v4l2_queryctrl is more difficult.

I can then remove existing code to cope with different versions of videodev2.h, too.

Cheers,

--
Sakari Ailus
sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to