On Mon June 18 2012 12:23:26 Laurent Pinchart wrote:
> Hi Hans,
>
> Thanks for the patch.
>
> On Sunday 10 June 2012 12:25:46 Hans Verkuil wrote:
> > From: Hans Verkuil <hans.verk...@cisco.com>
> >
> > Add helper functions to make it easier to adapt drivers to vb2.
>
> What about moving those functions to videobuf2-ioctl.c ? The helper functions
> are based on top of an existing vb2 core that isn't aware of queue ownership.
> It's not clear (to me at least) how the helpers will evolve and whether they
> will be used by all drivers or not, or whether part of what they do will get
> merged into the vb2 core. Splitting the helpers in a separate file would help
> not mixing code too much without really thinking about it.
Sounds reasonable. One thing that I want to think about when preparing RFCv2 is
whether the new queue_lock in video_device shouldn't be moved to vb2_queue
instead, since it is a per-vb2_queue lock. I need to check whether that still
makes it possible to split it up like you suggest. It almost certainly will make
sense to do this.
>
> > These helpers take care of core locking and check if the filehandle is the
> > owner of the queue.
> >
> > This patch also adds support for count == 0 in create_bufs.
>
> Could you please split that to its own patch ? The addition of
> __verify_memory_type() should be split as well.
OK.
Regards,
Hans
>
> > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
