Em 02-07-2012 11:15, Hans Verkuil escreveu:
> From: Hans Verkuil <hans.verk...@cisco.com>
> 
> Add a new ioctl to enumerate the supported frequency bands of a tuner.
> 
> Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
> ---
>   include/linux/videodev2.h |   36 ++++++++++++++++++++++++++----------
>   1 file changed, 26 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index f79d0cc..d54ec6e 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -2048,6 +2048,7 @@ struct v4l2_modulator {
>   #define V4L2_TUNER_CAP_RDS          0x0080
>   #define V4L2_TUNER_CAP_RDS_BLOCK_IO 0x0100
>   #define V4L2_TUNER_CAP_RDS_CONTROLS 0x0200
> +#define V4L2_TUNER_CAP_FREQ_BANDS    0x0400
>   
>   /*  Flags for the 'rxsubchans' field */
>   #define V4L2_TUNER_SUB_MONO         0x0001
> @@ -2066,19 +2067,30 @@ struct v4l2_modulator {
>   #define V4L2_TUNER_MODE_LANG1_LANG2 0x0004
>   
>   struct v4l2_frequency {
> -     __u32                 tuner;
> -     __u32                 type;     /* enum v4l2_tuner_type */
> -     __u32                 frequency;
> -     __u32                 reserved[8];
> +     __u32   tuner;
> +     __u32   type;   /* enum v4l2_tuner_type */
> +     __u32   frequency;
> +     __u32   reserved[8];
> +};
> +
> +struct v4l2_frequency_band {
> +     __u32   tuner;
> +     __u32   type;   /* enum v4l2_tuner_type */
> +     __u32   index;
> +     __u32   capability;
> +     __u32   rangelow;
> +     __u32   rangehigh;
> +     __u8    name[32];

As we've discussed, band name can be inferred from the frequency.
Also, there are more than one name for the same band (it could be
named based on the wavelength or frequency - also, some bands or
band segments may have special names, like Tropical Wave).
Let's userspace just call it whatever it wants. So, I'll just
drop it. 

On the other hand, the modulation is independent on the band, and
ITU-R and regulator agencies may allow more than one modulation type
and usage for the same frequency (like primary and secondary usage).

So, it makes sense to have an enum here to describe the modulation type
(currenly, AM, FM and VSB).

> +     __u32   reserved[6];
>   };
>   
>   struct v4l2_hw_freq_seek {
> -     __u32                 tuner;
> -     __u32                 type;     /* enum v4l2_tuner_type */
> -     __u32                 seek_upward;
> -     __u32                 wrap_around;
> -     __u32                 spacing;
> -     __u32                 reserved[7];
> +     __u32   tuner;
> +     __u32   type;   /* enum v4l2_tuner_type */
> +     __u32   seek_upward;
> +     __u32   wrap_around;
> +     __u32   spacing;
> +     __u32   reserved[7];
>   };
>   
>   /*
> @@ -2646,6 +2658,10 @@ struct v4l2_create_buffers {
>   #define VIDIOC_QUERY_DV_TIMINGS  _IOR('V', 99, struct v4l2_dv_timings)
>   #define VIDIOC_DV_TIMINGS_CAP   _IOWR('V', 100, struct v4l2_dv_timings_cap)
>   
> +/* Experimental, this ioctl may change over the next couple of kernel
> +   versions. */
> +#define VIDIOC_ENUM_FREQ_BANDS       _IOWR('V', 101, struct 
> v4l2_frequency_band)
> +
>   /* Reminder: when adding new ioctls please add support for them to
>      drivers/media/video/v4l2-compat-ioctl32.c as well! */
>   
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to