Hi Prabhakar, Just one small comment below.
On Friday 20 July 2012 20:28:09 Prabhakar Lad wrote: > From: Manjunath Hadli <manjunath.ha...@ti.com> > > add new enum entries for supporting the media-bus formats on dm365. > These include some bayer and some non-bayer formats. > V4L2_MBUS_FMT_YDYUYDYV8_1X16 and V4L2_MBUS_FMT_UV8_1X8 are used > internal to the hardware by the resizer. > V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8 represents the bayer ALAW format > that is supported by dm365 hardware. > > Acked-by: Hans Verkuil <hans.verk...@cisco.com> > Signed-off-by: Manjunath Hadli <manjunath.ha...@ti.com> > Signed-off-by: Lad, Prabhakar <prabhakar....@ti.com> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Sakari Ailus <sakari.ai...@iki.fi> > Cc: Guennadi Liakhovetski <g.liakhovet...@gmx.de> > --- > Documentation/DocBook/media/v4l/subdev-formats.xml | 250 ++++++++++++++++- > include/linux/v4l2-mediabus.h | 10 +- > 2 files changed, 252 insertions(+), 8 deletions(-) > @@ -2415,6 +2553,106 @@ > <entry>u<subscript>1</subscript></entry> > <entry>u<subscript>0</subscript></entry> > </row> > + <row id="V4L2-MBUS-FMT-YDYUYDYV8-1X16"> > + <entry>V4L2_MBUS_FMT_YDYUYDYV8_1X16</entry> > + <entry>0x2014</entry> > + <entry></entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>y<subscript>7</subscript></entry> > + <entry>y<subscript>6</subscript></entry> > + <entry>y<subscript>5</subscript></entry> > + <entry>y<subscript>4</subscript></entry> > + <entry>y<subscript>3</subscript></entry> > + <entry>y<subscript>2</subscript></entry> > + <entry>y<subscript>1</subscript></entry> > + <entry>y<subscript>0</subscript></entry> > + <entry>d<subscript>7</subscript></entry> > + <entry>d<subscript>6</subscript></entry> > + <entry>d<subscript>5</subscript></entry> > + <entry>d<subscript>4</subscript></entry> > + <entry>d<subscript>3</subscript></entry> > + <entry>d<subscript>2</subscript></entry> > + <entry>d<subscript>1</subscript></entry> > + <entry>d<subscript>0</subscript></entry> I would remove the subscripts for all the dummy bits (here and below), as they're dummy. With that change, Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > + </row> > + <row> > + <entry></entry> > + <entry></entry> > + <entry></entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>y<subscript>7</subscript></entry> > + <entry>y<subscript>6</subscript></entry> > + <entry>y<subscript>5</subscript></entry> > + <entry>y<subscript>4</subscript></entry> > + <entry>y<subscript>3</subscript></entry> > + <entry>y<subscript>2</subscript></entry> > + <entry>y<subscript>1</subscript></entry> > + <entry>y<subscript>0</subscript></entry> > + <entry>u<subscript>7</subscript></entry> > + <entry>u<subscript>6</subscript></entry> > + <entry>u<subscript>5</subscript></entry> > + <entry>u<subscript>4</subscript></entry> > + <entry>u<subscript>3</subscript></entry> > + <entry>u<subscript>2</subscript></entry> > + <entry>u<subscript>1</subscript></entry> > + <entry>u<subscript>0</subscript></entry> > + </row> > + <row> > + <entry></entry> > + <entry></entry> > + <entry></entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>y<subscript>7</subscript></entry> > + <entry>y<subscript>6</subscript></entry> > + <entry>y<subscript>5</subscript></entry> > + <entry>y<subscript>4</subscript></entry> > + <entry>y<subscript>3</subscript></entry> > + <entry>y<subscript>2</subscript></entry> > + <entry>y<subscript>1</subscript></entry> > + <entry>y<subscript>0</subscript></entry> > + <entry>d<subscript>7</subscript></entry> > + <entry>d<subscript>6</subscript></entry> > + <entry>d<subscript>5</subscript></entry> > + <entry>d<subscript>4</subscript></entry> > + <entry>d<subscript>3</subscript></entry> > + <entry>d<subscript>2</subscript></entry> > + <entry>d<subscript>1</subscript></entry> > + <entry>d<subscript>0</subscript></entry> > + </row> > + <row> > + <entry></entry> > + <entry></entry> > + <entry></entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>-</entry> > + <entry>y<subscript>7</subscript></entry> > + <entry>y<subscript>6</subscript></entry> > + <entry>y<subscript>5</subscript></entry> > + <entry>y<subscript>4</subscript></entry> > + <entry>y<subscript>3</subscript></entry> > + <entry>y<subscript>2</subscript></entry> > + <entry>y<subscript>1</subscript></entry> > + <entry>y<subscript>0</subscript></entry> > + <entry>v<subscript>7</subscript></entry> > + <entry>v<subscript>6</subscript></entry> > + <entry>v<subscript>5</subscript></entry> > + <entry>v<subscript>4</subscript></entry> > + <entry>v<subscript>3</subscript></entry> > + <entry>v<subscript>2</subscript></entry> > + <entry>v<subscript>1</subscript></entry> > + <entry>v<subscript>0</subscript></entry> > + </row> > <row id="V4L2-MBUS-FMT-YUYV10-1X20"> > <entry>V4L2_MBUS_FMT_YUYV10_1X20</entry> > <entry>0x200d</entry> -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
