On 08/22/2012 01:56 AM, Antti Palosaari wrote: > This is workaround / partial fix. > > rtl2832u_power_ctrl() and rtl2832u_frontend_attach() needs to > be go through carefully and fix properly. There is clearly > some logical errors when handling power-management ang GPIOs... > > Signed-off-by: Antti Palosaari <cr...@iki.fi> > Cc: Thomas Mair <thomas.mai...@googlemail.com> > --- > drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > index 1ccb99b..c246c50 100644 > --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > @@ -946,17 +946,6 @@ static int rtl2832u_power_ctrl(struct dvb_usb_device *d, > int onoff) > if (ret) > goto err; > > - /* demod HW reset */ > - ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val); > - if (ret) > - goto err; > - /* bit 5 to 0 */ > - val &= 0xdf; > - > - ret = rtl28xx_wr_reg(d, SYS_DEMOD_CTL, val); > - if (ret) > - goto err; > - > ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val); > if (ret) > goto err; >
Test: PASSED! Working zapping on every hard/cold boot, soft/warm [re]boot and every module(dvb_usb_rtl28xxu) [re]load. Outside the box thinking! Antti, thank you very much! media_build commit 420335f564c32517a791ecea3909af233925634d 1f4d:b803 G-Tek Electronics Group Lifeview LV5TDLX DVB-T [RTL2832U] Cheers, poma -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
