Hi Hans,

Thanks for the patch.

On Friday 07 September 2012 15:29:15 Hans Verkuil wrote:
> From: Hans Verkuil <[email protected]>
> 
> While the documentation says that VIDIOC_CROPCAP is compulsory for
> all video capture and output devices, in practice VIDIOC_CROPCAP is
> only implemented for devices that can do cropping and/or scaling.
> 
> Update the documentation to no longer require VIDIOC_CROPCAP if the
> driver does not support cropping or scaling or non-square pixels.
> 
> Signed-off-by: Hans Verkuil <[email protected]>
> ---
>  Documentation/DocBook/media/v4l/common.xml         |  145 ++++++++---------
>  Documentation/DocBook/media/v4l/vidioc-cropcap.xml |   10 +-
>  2 files changed, 75 insertions(+), 80 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/common.xml
> b/Documentation/DocBook/media/v4l/common.xml index 9378d7b..454258b 100644
> --- a/Documentation/DocBook/media/v4l/common.xml
> +++ b/Documentation/DocBook/media/v4l/common.xml
> @@ -628,7 +628,7 @@ are available for the device.</para>
>  if (-1 == ioctl (fd, &VIDIOC-G-STD;, &amp;std_id)) {
>       /* Note when VIDIOC_ENUMSTD always returns EINVAL this
>          is no video device or it falls under the USB exception,
> -        and VIDIOC_G_STD returning EINVAL is no error. */
> +        and VIDIOC_G_STD returning ENOTTY is no error. */
> 
>       perror ("VIDIOC_G_STD");
>       exit (EXIT_FAILURE);

Would this hunk make more sense in patch 11/28 ?

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to