[PATCH 1/3] ov2640: select sensor register bank before applying h/v-flip settings

[Frank Schäfer]

We currently don't select the register bank in ov2640_s_ctrl, so we can end up
writing to DSP register 0x04 instead of sensor register 0x04.
This happens for example when calling ov2640_s_ctrl after ov2640_s_fmt.

Signed-off-by: Frank Schäfer <fschaefer....@googlemail.com>
Cc: sta...@kernel.org
---
 drivers/media/i2c/soc_camera/ov2640.c |    8 ++++++++
 1 Datei geändert, 8 Zeilen hinzugefügt(+)

diff --git a/drivers/media/i2c/soc_camera/ov2640.c 
b/drivers/media/i2c/soc_camera/ov2640.c
index 78ac574..e4fc79e 100644
--- a/drivers/media/i2c/soc_camera/ov2640.c
+++ b/drivers/media/i2c/soc_camera/ov2640.c
@@ -683,8 +683,16 @@ static int ov2640_s_ctrl(struct v4l2_ctrl *ctrl)
        struct v4l2_subdev *sd =
                &container_of(ctrl->handler, struct ov2640_priv, hdl)->subdev;
        struct i2c_client  *client = v4l2_get_subdevdata(sd);
+       struct regval_list regval;
+       int ret;
        u8 val;
 
+       regval.reg_num = BANK_SEL;
+       regval.value = BANK_SEL_SENS;
+       ret = ov2640_write_array(client, &regval);
+       if (ret < 0)
+               return ret;
+
        switch (ctrl->id) {
        case V4L2_CID_VFLIP:
                val = ctrl->val ? REG04_VFLIP_IMG : 0x00;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html