On Fri, Oct 05, 2012 at 06:54:58PM -0700, Andrey Smirnov wrote: > + err = regulator_enable(core->supplies.va); > + if (err < 0) > + break; > + > + err = regulator_enable(core->supplies.vio2); > + if (err < 0) > + goto disable_va; > + > + err = regulator_enable(core->supplies.vd); > + if (err < 0) > + goto disable_vio2; > + > + err = regulator_enable(core->supplies.vio1); > + if (err < 0) > + goto disable_vd;
If the sequencing is critical here you should have comments explaining what the requirement is, otherwise this looks like a prime candidate for conversion to regulator_bulk_enable() (and similarly for all the other regulator usage, it appears that all the regulators are worked with in a bulk fashion). -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
