On 10/27/2012 02:31 PM, Mark Brown wrote: > On Thu, Oct 25, 2012 at 03:26:02PM -0700, Andrey Smirnov wrote: >> On 10/25/2012 12:45 PM, Mark Brown wrote: >>> This really makes little sense to me, why are you doing this? Does the >>> device *really* layer a byte stream on top of I2C for sending messages >>> that look like marshalled register reads and writes? >> The SI476x chips has a concept of a "property". Each property having >> 16-bit address and 16-bit value. At least a portion of a chip >> configuration is done by modifying those properties. In order to > Right, that's what I remembered from previous code. There's no way this > should be a regmap bus - a bus is something that gets data serialised by > the core into a byte stream, having the data rendered down into a byte > stream and then reparsing it is a bit silly. The device should be > hooking in before the data gets marshalled which we can't currently do > but it shouldn't be too hard to make it so that we can have register > read and write functions supplied in the regmap config.
Oh, now I think I see what you mean. I have two agree with you, I don't think I like what I am doing in my code. I'll try to familiarize myself with 'regmap' code and come up with the way to extend the framework. And I just wanted to upstream my simple radio driver... :-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
